flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2354] Add job graph and checkpoint reco...
Date Mon, 05 Oct 2015 14:46:47 GMT
Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1153#discussion_r41152041
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
    @@ -110,61 +120,68 @@
     
     	public CheckpointCoordinator(
     			JobID job,
    -			int numSuccessfulCheckpointsToRetain,
     			long checkpointTimeout,
     			ExecutionVertex[] tasksToTrigger,
     			ExecutionVertex[] tasksToWaitFor,
     			ExecutionVertex[] tasksToCommitTo,
    -			ClassLoader userClassLoader) {
    +			ClassLoader userClassLoader,
    +			CheckpointIDCounter checkpointIDCounter,
    +			CompletedCheckpoints completedCheckpoints,
    +			RecoveryMode recoveryMode) throws Exception {
     		
     		// some sanity checks
     		if (job == null || tasksToTrigger == null ||
     				tasksToWaitFor == null || tasksToCommitTo == null) {
     			throw new NullPointerException();
     		}
    -		if (numSuccessfulCheckpointsToRetain < 1) {
    -			throw new IllegalArgumentException("Must retain at least one successful checkpoint");
    -		}
     		if (checkpointTimeout < 1) {
     			throw new IllegalArgumentException("Checkpoint timeout must be larger than zero");
     		}
     		
     		this.job = job;
    --- End diff --
    
    Yes, I've changed it in some places and not in others


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message