flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vasia <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2785] [gelly] implements fromCsvReader ...
Date Tue, 06 Oct 2015 17:37:46 GMT
Github user vasia commented on the pull request:

    https://github.com/apache/flink/pull/1205#issuecomment-145939652
  
    Thanks so much for the review @fhueske!
    I agree with your comments. I will rename the parameter to `readVertices`, make it mandatory,
and better explain it on the docs. I also like the suggestion for `edgeValue` -> `hasEdgeValues`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message