flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2731][web-dashboard] Adds access to Job...
Date Wed, 07 Oct 2015 14:16:31 GMT
Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1233#discussion_r41395166
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
    @@ -139,7 +148,14 @@ else if (flinkRoot != null) {
     			throw new IllegalConfigurationException("The path to the static contents (" + 
     					webRootDir.getAbsolutePath() + ") is not a readable directory.");
     		}
    -		
    +
    +		final File logStdoutDir = new File(flinkRoot, LOG_OUTPUT_DIRECTORY);
    --- End diff --
    
    i like `logDir` is more consistent


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message