flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2731][web-dashboard] Adds access to Job...
Date Wed, 07 Oct 2015 14:17:58 GMT
Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1233#discussion_r41395336
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/StaticFileServerHandler.java
---
    @@ -123,9 +124,18 @@ public void channelRead0(ChannelHandlerContext ctx, Routed routed)
throws Except
     		final HttpRequest request = routed.request();
     		String requestPath = routed.path();
     
    +		// TODO REMOVE BEFORE COMMITTING. THIS IS ONLY TO TEST THAT JOB MANAGER STDOUT IS ACCESSED
    +		System.out.println(requestPath);
    +
     		// make sure we request the "index.html" in case there is a directory request
     		if (requestPath.endsWith("/")) {
     			requestPath = requestPath + "index.html";
    +		} else if (requestPath.equals("/jobmanager/logfile")) {
    +			requestPath = "/" + WebRuntimeMonitor.LOG_FILE_PATH;
    +		} else if (requestPath.equals("/jobmanager/stdout")) {
    +			requestPath = "/" + WebRuntimeMonitor.STDOUT_FILE_PATH;
    +		} else {
    --- End diff --
    
    the else comment is confusing. please remove


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message