flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2731][web-dashboard] Adds access to Job...
Date Wed, 07 Oct 2015 14:18:21 GMT
Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1233#discussion_r41395372
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/StaticFileServerHandler.java
---
    @@ -177,7 +187,11 @@ public void channelRead0(ChannelHandlerContext ctx, Routed routed)
throws Except
     
     		HttpResponse response = new DefaultHttpResponse(HTTP_1_1, OK);
     		setContentTypeHeader(response, file);
    -		setDateAndCacheHeaders(response, file);
    +		// TODO This is counter-intuitive. Will be changed later when a dynamic file server
is added
    --- End diff --
    
    please remove this special branch. what is confusing exactly?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message