flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1789] [core] [runtime] [java-api] Allow...
Date Thu, 08 Oct 2015 08:40:49 GMT
Github user mxm commented on a diff in the pull request:

    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/RemoteEnvironment.java ---
    @@ -55,21 +59,8 @@
     	/** Optional shutdown hook, used in session mode to eagerly terminate the last session
     	private Thread shutdownHook;
    -	/**
    -	 * Creates a new RemoteEnvironment that points to the master (JobManager) described
by the
    -	 * given host name and port.
    -	 * 
    -	 * <p>Each program execution will have all the given JAR files in its classpath.
    -	 * 
    -	 * @param host The host name or address of the master (JobManager), where the program
should be executed.
    -	 * @param port The port of the master (JobManager), where the program should be executed.

    -	 * @param jarFiles The JAR files with code that needs to be shipped to the cluster.
If the program uses
    -	 *                 user-defined functions, user-defined input formats, or any libraries,
those must be
    -	 *                 provided in the JAR files.
    -	 */	
    -	public RemoteEnvironment(String host, int port, String... jarFiles) {
    --- End diff --
    Could we keep this constructor?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message