flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2730][web-dashboard] Adds cpu and memor...
Date Fri, 09 Oct 2015 10:41:00 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1236#discussion_r41617830
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
    @@ -536,6 +536,11 @@ class JobManager(
             )
           )
     
    +    case RequestTaskManagerInstance(instanceID) =>
    +      sender ! decorateMessage(
    +        TaskManagerInstance(instanceManager.getRegisteredInstanceById(instanceID))
    +      )
    +
    --- End diff --
    
    Wouldn't it be better to return an InstanceNotFound message instead of a null instance?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message