flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danielblazevski <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...
Date Wed, 14 Oct 2015 17:27:09 GMT
Github user danielblazevski commented on the pull request:

    https://github.com/apache/flink/pull/1220#issuecomment-148125833
  
    @tillrohrmann I fixed a couple of typos and verified that center/width of the root node
are what they should be based on the input of MinVec and MaxVec.  `partitionBox` is not running
in an infinite loop, but insertRecur is, which seems due to the output of `partitionBox`
    
    ```
    center = DenseVector(1.0, -0.5)
    width = DenseVector(0.0, 0.0)
    box    List(DenseVector(1.0, -0.5), DenseVector(1.0, -0.5), DenseVector(1.0, -0.5), DenseVector(1.0,
-0.5))
    ```
    The output is `box` printed out on the base-case of the recursion, namely:
    ```scala
           if (dim >= width.size) {
              println("box    " + box)
              box
    ```
    The centers are not computed correctly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message