flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sachingoel0101 <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...
Date Thu, 22 Oct 2015 17:28:19 GMT
Github user sachingoel0101 commented on a diff in the pull request:

    --- Diff: flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java
    @@ -139,6 +140,69 @@ public void shouldSubmitToJobClient() {
    +	 * Tests that invalid detached mode programs fail.
    +	 */
    +	@Test
    +	public void testDetachedMode() throws Exception{
    +		jobManagerSystem.actorOf(Props.create(SuccessReturningActor.class), JobManager.JOB_MANAGER_NAME());
    +		Client out = new Client(config);
    +		try {
    +			PackagedProgram prg = new PackagedProgram(TestExecuteTwice.class, "/dev/random", "/tmp");
    --- End diff --
    Actually, these arguments are not needed. I will simply remove them.
    Also, in `textGetExecutionPlan` where these values are used, the locations are not actually
accessed. Only plan is tested. So shouldn't be an issue.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message