flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From greghogan <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2897] [runtime] Use distinct initial in...
Date Fri, 23 Oct 2015 13:12:14 GMT
Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1292#discussion_r42862734
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/shipping/OutputEmitter.java
---
    @@ -143,14 +148,25 @@ public OutputEmitter(ShipStrategyType strategy, TypeComparator<T>
comparator, Pa
     	
     	// --------------------------------------------------------------------------------------------
     
    +	private int[] forward() {
    +		if (this.channels == null) {
    --- End diff --
    
    Yes, I did overlook that, though customPartition does likewise and the OutputEmitter will
only be used for a single strategy. The strategy is set in the constructor so the channel
list can be created there for the types which do not broadcast.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message