flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From willmiao <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...
Date Mon, 26 Oct 2015 10:25:35 GMT
Github user willmiao commented on the pull request:

    https://github.com/apache/flink/pull/1121#issuecomment-151092573
  
    hi @rmetzger ,
    I believe I find the reason why my test failed.
    A test will fail if we don’t specify “-t” argument(_which is an optional argument_)
in the command when call runWithArgs function, and we will get exception here:
    ```
    Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/log4j/Level
        at org.apache.hadoop.mapred.JobConf.<clinit>(JobConf.java:357)
    ```
    It seems some jar files relevant to log callback are needed.
    
    One more thing, I noticed a segment of code as follows in the file “FlinkYarnSessionCli.java”:
    ```
    File logback = new File(confDirPath + File.pathSeparator + CONFIG_FILE_LOGBACK_NAME);
    if (logback.exists()) {
    shipFiles.add(logback);
        flinkYarnClient.setFlinkLoggingConfigurationPath(new Path(logback.toURI()));
    }
    ```
    And I wonder if “**File.pathSeparator**” should be “**File.separator**” here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message