flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2918] Add method to read a file of type...
Date Mon, 26 Oct 2015 13:01:28 GMT
Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/1299#issuecomment-151125493
  
    LGTM. The `readAsSequenceFile` is nice syntactic sugar to add. But we should add documentation
to the online documentation since it's the user facing API which we extend here.
    
    Furthermore, we should think about adding a corresponding `writeAsSequenceFile` method
to the `DataSet` as the counter-part to `readAsSequenceFile`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message