flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...
Date Mon, 26 Oct 2015 17:49:36 GMT
Github user mxm commented on the pull request:

    https://github.com/apache/flink/pull/1214#issuecomment-151224527
  
    I took a look at this again because I wanted to merge it for 0.10. However, I think it
still needs a bit of work. The `ContextEnvironmentFactory` shouldn't hold the state for detached
batch and stream executions. Could you store the batch plan in the `ContextEnvironment` and
the stream graph in the `StreamContextEnvironment` (non-static)? Please give them appropriate
names.
    
    Since the `ContextEnvironmentFactory` is currently the entry point for batch and streaming
execution (the streaming environment just checks whether the `ContextEnvironment` is instantiated),
you may set a flag in the factory to prevent multiple executions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message