flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1599) TypeComperator with no keys and comparators matches some elements
Date Thu, 01 Oct 2015 15:47:26 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939995#comment-14939995
] 

ASF GitHub Bot commented on FLINK-1599:
---------------------------------------

GitHub user mxm opened a pull request:

    https://github.com/apache/flink/pull/1207

    [FLINK-1599] TypeComperator with no keys and comparators matches some elements

    - update JavaDoc to clarify the usage of the extractKey(..) and getFlatComparators() method

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mxm/flink FLINK-1599

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1207.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1207
    
----
commit 44e83afd8510c8303ef015d38dc3e576ee7d2257
Author: Maximilian Michels <mxm@apache.org>
Date:   2015-10-01T15:42:42Z

    [FLINK-1599] TypeComperator with no keys and comparators matches some elements
    
    - update JavaDoc to clarify the usage of the extractKey(..) and
      getFlatComparators() method

----


> TypeComperator with no keys and comparators matches some elements
> -----------------------------------------------------------------
>
>                 Key: FLINK-1599
>                 URL: https://issues.apache.org/jira/browse/FLINK-1599
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Runtime
>    Affects Versions: 0.8.0
>            Reporter: Maximilian Michels
>            Priority: Minor
>
> If you create a custom type comparator by subclassing {{TypeComperator}} and implement
{{int extractKeys(Object record, Object[] target, int index)}} and {{TypeComparator[] getFlatComparators()}}
to return 0 and no type comparators respectively, the {{coGroup}} operator (possibly others)
find matching elements although no comparators have been specified.
> In this case, the expected behavior for a CoGroup would be that only elements from one
side are supplied in the CoGroup method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message