flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maximilian Michels (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (FLINK-2236) RowSerializer and CaseClassComparator are not in sync regarding Null-Values
Date Tue, 06 Oct 2015 09:58:27 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943434#comment-14943434
] 

Maximilian Michels edited comment on FLINK-2236 at 10/6/15 9:58 AM:
--------------------------------------------------------------------

Note that FLINK-2203 has already been merged to the master. I'll revert the commit {{f8e12b20d925c3f6f24769327d1da5d98affa679}}
and close this issue with Won't Fix.


was (Author: mxm):
Note that the subtask has already been merged to the master. We need to revert {{f8e12b20d925c3f6f24769327d1da5d98affa679}}
or fix this issue.

> RowSerializer and CaseClassComparator are not in sync regarding Null-Values
> ---------------------------------------------------------------------------
>
>                 Key: FLINK-2236
>                 URL: https://issues.apache.org/jira/browse/FLINK-2236
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: 0.10
>            Reporter: Aljoscha Krettek
>            Priority: Blocker
>             Fix For: 0.10
>
>
> The RowSerializer was recently updated to allow it to handle null values. This changes
the binary layout of the serialised data. CaseClassComparator, which is used for comparison,
is not aware of this new layout and therefore fails. The problem only occurs when a key is
long enough to exceed the normalised-key length, that's why the tests fail to notice the bug.
> I think the solution is to modify all Tuple-like serializers/comparators (TupleComparatorBase,
CaseClassComparator, TupleSerializer, CaseClassSerializer, RowSerializer) to handle null-values,
thus bringing the binary format in sync again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message