flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2613) Print usage information for Scala Shell
Date Thu, 01 Oct 2015 08:33:26 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939500#comment-14939500
] 

ASF GitHub Bot commented on FLINK-2613:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1106#discussion_r40889842
  
    --- Diff: flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
---
    @@ -0,0 +1,148 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.scala
    +
    +
    +import java.io.{StringWriter, BufferedReader}
    +
    +import scala.tools.nsc.Settings
    +
    +import org.apache.flink.configuration.Configuration
    +import org.apache.flink.runtime.minicluster.LocalFlinkMiniCluster
    +
    +import scala.tools.nsc.interpreter._
    +
    +
    +object FlinkShell {
    +
    +  val LOCAL = 0;
    +  val REMOTE = 1;
    +  val UNDEFINED = -1;
    --- End diff --
    
    Can we use an enum for that?


> Print usage information for Scala Shell
> ---------------------------------------
>
>                 Key: FLINK-2613
>                 URL: https://issues.apache.org/jira/browse/FLINK-2613
>             Project: Flink
>          Issue Type: Improvement
>          Components: Scala Shell
>    Affects Versions: 0.10
>            Reporter: Maximilian Michels
>            Assignee: Nikolaas Steenbergen
>            Priority: Minor
>              Labels: starter
>             Fix For: 0.10
>
>
> The Scala Shell startup script starts a {{FlinkMiniCluster}} by default if invoked with
no arguments.
> We should add a {{--help}} or {{-h}} option to make it easier for people to find out
how to configure remote execution. Alternatively, we could print a notice on the local startup
explaining how to start the shell in remote mode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message