flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2613) Print usage information for Scala Shell
Date Thu, 08 Oct 2015 14:20:27 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14948726#comment-14948726
] 

ASF GitHub Bot commented on FLINK-2613:
---------------------------------------

Github user chiwanpark commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1106#discussion_r41518604
  
    --- Diff: flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkILoop.scala
---
    @@ -34,16 +34,16 @@ class FlinkILoop(
         out0: JPrintWriter)
       extends ILoopCompat(in0, out0) {
     
    -  def this(host:String, 
    -           port:Int, 
    -           externalJars : Option[Array[String]], 
    +  def this(host: String,
    +           port: Int,
    +           externalJars: Option[Array[String]],
                in0: BufferedReader, 
                out: JPrintWriter){
    -    this(host:String, port:Int, externalJars, Some(in0), out)
    +    this(host: String, port: Int, externalJars, Some(in0), out)
       }
     
    -  def this(host:String, port:Int, externalJars : Option[Array[String]]){
    -    this(host:String,port: Int, externalJars , None, new JPrintWriter(Console.out, true))
    +  def this(host: String, port: Int, externalJars: Option[Array[String]]){
    +    this(host: String, port: Int, externalJars , None, new JPrintWriter(Console.out,
true))
    --- End diff --
    
    Please remove space after `externalJars`


> Print usage information for Scala Shell
> ---------------------------------------
>
>                 Key: FLINK-2613
>                 URL: https://issues.apache.org/jira/browse/FLINK-2613
>             Project: Flink
>          Issue Type: Improvement
>          Components: Scala Shell
>    Affects Versions: 0.10
>            Reporter: Maximilian Michels
>            Assignee: Nikolaas Steenbergen
>            Priority: Minor
>              Labels: starter
>             Fix For: 0.10
>
>
> The Scala Shell startup script starts a {{FlinkMiniCluster}} by default if invoked with
no arguments.
> We should add a {{--help}} or {{-h}} option to make it easier for people to find out
how to configure remote execution. Alternatively, we could print a notice on the local startup
explaining how to start the shell in remote mode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message