flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2624) RabbitMQ source / sink should participate in checkpointing
Date Fri, 16 Oct 2015 14:23:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14960774#comment-14960774
] 

ASF GitHub Bot commented on FLINK-2624:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1243#discussion_r42247633
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/MessageAcknowledingSourceBase.java
---
    @@ -144,6 +152,20 @@ protected void addId(Id id) {
     	
     	@Override
     	public SerializedCheckpointData[] snapshotState(long checkpointId, long checkpointTimestamp)
throws Exception {
    +		if (idsForCurrentCheckpoint == null) {
    --- End diff --
    
    I think these checks are pretty redundant. The tasks should guarantee that no calls happen
on non-open functions, or closed functions.


> RabbitMQ source / sink should participate in checkpointing
> ----------------------------------------------------------
>
>                 Key: FLINK-2624
>                 URL: https://issues.apache.org/jira/browse/FLINK-2624
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming Connectors
>    Affects Versions: 0.10
>            Reporter: Stephan Ewen
>            Assignee: Hilmi Yildirim
>
> The RabbitMQ connector does not offer any fault tolerance guarantees right now, because
it does not participate in the checkpointing.
> We should integrate it in a similar was as the {{FlinkKafkaConsumer}} is integrated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message