flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2731) Add JobManager log file access
Date Wed, 07 Oct 2015 14:18:27 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946919#comment-14946919
] 

ASF GitHub Bot commented on FLINK-2731:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1233#discussion_r41395336
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/StaticFileServerHandler.java
---
    @@ -123,9 +124,18 @@ public void channelRead0(ChannelHandlerContext ctx, Routed routed)
throws Except
     		final HttpRequest request = routed.request();
     		String requestPath = routed.path();
     
    +		// TODO REMOVE BEFORE COMMITTING. THIS IS ONLY TO TEST THAT JOB MANAGER STDOUT IS ACCESSED
    +		System.out.println(requestPath);
    +
     		// make sure we request the "index.html" in case there is a directory request
     		if (requestPath.endsWith("/")) {
     			requestPath = requestPath + "index.html";
    +		} else if (requestPath.equals("/jobmanager/logfile")) {
    +			requestPath = "/" + WebRuntimeMonitor.LOG_FILE_PATH;
    +		} else if (requestPath.equals("/jobmanager/stdout")) {
    +			requestPath = "/" + WebRuntimeMonitor.STDOUT_FILE_PATH;
    +		} else {
    --- End diff --
    
    the else comment is confusing. please remove


> Add JobManager log file access
> ------------------------------
>
>                 Key: FLINK-2731
>                 URL: https://issues.apache.org/jira/browse/FLINK-2731
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Webfrontend
>    Affects Versions: 0.10
>            Reporter: Stephan Ewen
>            Assignee: Sachin Goel
>             Fix For: 0.10
>
>
> Add access to the JobManager log file and out file in the web dashboard



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message