flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2741) Use single log statement in TestLogger
Date Sat, 03 Oct 2015 22:58:26 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942494#comment-14942494
] 

ASF GitHub Bot commented on FLINK-2741:
---------------------------------------

GitHub user rerngvit opened a pull request:

    https://github.com/apache/flink/pull/1221

    [FLINK-2741] - Use single log statement in TestLogger

    [FLINK-2741] - Use single log statement in TestLogger

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rerngvit/flink FLINK-2741

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1221.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1221
    
----
commit 2b9e5972d5c7d01f066932187bf9620cd560db9e
Author: Rerngvit Yanggratoke <rerngvit@kth.se>
Date:   2015-10-03T22:57:21Z

    [FLINK-2741] - Use single log statement in TestLogger

----


> Use single log statement in TestLogger
> --------------------------------------
>
>                 Key: FLINK-2741
>                 URL: https://issues.apache.org/jira/browse/FLINK-2741
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: master
>            Reporter: Ufuk Celebi
>            Assignee: rerngvit yanggratoke
>            Priority: Trivial
>
> {{TestLogger}} prints log statements before and after tests. Currently this is done via
multiple {{log.info}} statements. Sometimes this leads to interleaved output with failure
stack traces.
> I would like to change it to a single statements with new lines:
> {code}
> 17:30:31,887 ERROR A  - ---------------------------------------------
> 17:30:31,891 INFO  B  - Shutting down remote daemon.
> 17:30:31,895 ERROR A  - Test testJobManagerCleanUp(A) failed with:
> ...
> 17:30:31,909 ERROR A  - =============================================
> {code}
> to
> {code}
> 17:30:31,891 INFO  B  - Shutting down remote daemon.
> 17:30:31,887 ERROR A  -
> ---------------------------------------------------------------------
> Test testJobManagerCleanUp(A) failed with:
> ...
> =====================================================================
> {code}
> Any opinions? Does this improve readability?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message