flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2741) Use single log statement in TestLogger
Date Sun, 04 Oct 2015 23:32:26 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942861#comment-14942861
] 

ASF GitHub Bot commented on FLINK-2741:
---------------------------------------

Github user chiwanpark commented on the pull request:

    https://github.com/apache/flink/pull/1221#issuecomment-145401720
  
    I'm not sure this patch is ready to merge. Because of additional components for log such
as time, thread name, caller class name, etc., the log output is not same after merging this
changes.
    
    I'm inclined to preserve the current implementation.


> Use single log statement in TestLogger
> --------------------------------------
>
>                 Key: FLINK-2741
>                 URL: https://issues.apache.org/jira/browse/FLINK-2741
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: master
>            Reporter: Ufuk Celebi
>            Assignee: rerngvit yanggratoke
>            Priority: Trivial
>
> {{TestLogger}} prints log statements before and after tests. Currently this is done via
multiple {{log.info}} statements. Sometimes this leads to interleaved output with failure
stack traces.
> I would like to change it to a single statements with new lines:
> {code}
> 17:30:31,887 ERROR A  - ---------------------------------------------
> 17:30:31,891 INFO  B  - Shutting down remote daemon.
> 17:30:31,895 ERROR A  - Test testJobManagerCleanUp(A) failed with:
> ...
> 17:30:31,909 ERROR A  - =============================================
> {code}
> to
> {code}
> 17:30:31,891 INFO  B  - Shutting down remote daemon.
> 17:30:31,887 ERROR A  -
> ---------------------------------------------------------------------
> Test testJobManagerCleanUp(A) failed with:
> ...
> =====================================================================
> {code}
> Any opinions? Does this improve readability?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message