flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2748) Accumulator fetch failure leads to duplicate job result response
Date Thu, 01 Oct 2015 15:58:26 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940006#comment-14940006
] 

ASF GitHub Bot commented on FLINK-2748:
---------------------------------------

Github user uce commented on the pull request:

    https://github.com/apache/flink/pull/1206#issuecomment-144771060
  
    Of course only merge if the builds pass. You are catching IOException but it should be
Exception as before.


> Accumulator fetch failure leads to duplicate job result response
> ----------------------------------------------------------------
>
>                 Key: FLINK-2748
>                 URL: https://issues.apache.org/jira/browse/FLINK-2748
>             Project: Flink
>          Issue Type: Bug
>          Components: JobManager
>    Affects Versions: master
>            Reporter: Ufuk Celebi
>            Assignee: Maximilian Michels
>
> On {{JobStatusChanged}} message and a failure to catch the accumulator result the client
will receive a {{JobResultFailure}} and {{JobResultSuccess}} response
> {code}
> newJobStatus match {
>   case JobStatus.FINISHED =>
>     val accumulatorResults: java.util.Map[String, SerializedValue[AnyRef]] = try {
>       executionGraph.getAccumulatorsSerialized()
>     } catch {
>       case e: Exception =>
>         log.error(s"Cannot fetch final accumulators for job $jobID", e)
>         val exception = new JobExecutionException(jobID,
>           "Failed to retrieve accumulator results.", e)
>         jobInfo.client ! decorateMessage(JobResultFailure(
>           new SerializedThrowable(exception)))
>         Collections.emptyMap()  <<< HERE
>     }
>   val result = new SerializedJobExecutionResult(
>     jobID,
>     jobInfo.duration,
>     accumulatorResults)
>     jobInfo.client ! decorateMessage(JobResultSuccess(result)) <<< HERE
> {code}
> Furthermore the indentation is off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message