flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2785) Implement Graph's fromCsvReader in Gelly-Scala
Date Thu, 01 Oct 2015 13:14:26 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939792#comment-14939792
] 

ASF GitHub Bot commented on FLINK-2785:
---------------------------------------

GitHub user vasia opened a pull request:

    https://github.com/apache/flink/pull/1205

    [FLINK-2785] [gelly] implements fromCsvReader for gelly-scala

    This is the last method missing from the Scala Graph implementation.
    In order to be as close as possible to the Java implementation, I implemented one method
where different options are given with optional parameters. This resulted into the method
exceeding the allowed max number of parameters, as defined in the scala checkstyle. I decided
to disable the checkstyle for this particular method, because most of the parameters are optional
and are there mainly for completeness. In the common case, a user would only give the path
and delimiters. If you think there's a better way to do this without having to disable the
checkstyle, let me know!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vasia/flink gelly-readCsv

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1205.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1205
    
----
commit efe84acd8180f1cc4ece197c9b5193f8a926a98f
Author: vasia <vasia@apache.org>
Date:   2015-09-30T21:53:06Z

    [FLINK-2785] [gelly] implement fromCsvReader for gelly-scala; add tests and docs

----


> Implement Graph's fromCsvReader in Gelly-Scala
> ----------------------------------------------
>
>                 Key: FLINK-2785
>                 URL: https://issues.apache.org/jira/browse/FLINK-2785
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Gelly
>            Reporter: Vasia Kalavri
>            Assignee: Vasia Kalavri
>            Priority: Minor
>
> Graphs's {{fromCsvReader}} method is currently missing from the Gelly Scala API. It cannot
be implemented as a simple wrapper over the Java method, because the Java method returns a
{{GraphCsvReader}}, which in return creates a Graph after specifying types with appropriate
methods. The Scala version of the method can be more nicely implemented using the {{ScalaCsvInputFormat}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message