flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2785) Implement Graph's fromCsvReader in Gelly-Scala
Date Tue, 06 Oct 2015 19:19:26 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945612#comment-14945612
] 

ASF GitHub Bot commented on FLINK-2785:
---------------------------------------

Github user chiwanpark commented on the pull request:

    https://github.com/apache/flink/pull/1205#issuecomment-145970361
  
    I'm worrying about the name of method `fromCsvReader`. It seems that the method should
receive `CsvReader` object and read graph data from the reader object. Why we don't use other
name such as `fromCsvFile`?


> Implement Graph's fromCsvReader in Gelly-Scala
> ----------------------------------------------
>
>                 Key: FLINK-2785
>                 URL: https://issues.apache.org/jira/browse/FLINK-2785
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Gelly
>            Reporter: Vasia Kalavri
>            Assignee: Vasia Kalavri
>            Priority: Minor
>
> Graphs's {{fromCsvReader}} method is currently missing from the Gelly Scala API. It cannot
be implemented as a simple wrapper over the Java method, because the Java method returns a
{{GraphCsvReader}}, which in return creates a Graph after specifying types with appropriate
methods. The Scala version of the method can be more nicely implemented using the {{ScalaCsvInputFormat}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message