flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2815) [REFACTOR] Remove Pact from class and file names since it is no longer valid reference
Date Sat, 03 Oct 2015 03:56:26 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942089#comment-14942089
] 

ASF GitHub Bot commented on FLINK-2815:
---------------------------------------

GitHub user hsaputra opened a pull request:

    https://github.com/apache/flink/pull/1218

    [FLINK-2815] [REFACTOR] Remove Pact from class and file names since it is no longer valid
reference

    Remove Pact word from class and file names in Apache Flink.
    Pact was the name used in Stratosphere time to refer to concept of distributed datasets
(similar to Flink Dataset). It was used when Pact and Nephele still separate concept.
    
    As part of 0.10.0 release cleanup effort, let's remove the Pact names to avoid confusion.
    
    The PR also contains small cleanups (sorry):
    1. Small refactor DataSinkTask and DataSourceTask to follow Java7 generic convention creation
new collection. Remove LOG.isDebugEnabled check.
    2. Simple cleanup to update MapValue and TypeInformation with Java7 generic convention
creation new collection.
    3. Combine several exceptions that have same catch operation.
    
    Apologize for the extra changes with PR. But I separated them into different commits for
easier review.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hsaputra/flink remove_pact_name

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1218.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1218
    
----
commit 0c562f4b37f448a8cb408d70aa301e6d861a464d
Author: hsaputra <hsaputra@apache.org>
Date:   2015-10-01T21:58:19Z

    Small refactor on DataSinkTask and DataSourceTask classes to keep up with modern Java
practice.

commit 6403d44a9547b8a7f52f4795cd5ef4a72533906f
Author: hsaputra <hsaputra@apache.org>
Date:   2015-10-02T18:16:59Z

    Remove the word Pact from the Javadoc for ChainedDriver.

commit df2f553a7e46d18523521cfb18a402cc08ac5fce
Author: hsaputra <hsaputra@apache.org>
Date:   2015-10-02T19:24:57Z

    Use Java7 style of type resolution for new collection.

commit dbb217589178b4b7e7b059b352a867dfc4749856
Author: hsaputra <hsaputra@apache.org>
Date:   2015-10-02T22:03:50Z

    Simple cleanup to update MapValue with Java7 generic for new collection. Remove unused
imports in CollectionsDataTypeTest.

commit e085f38958b62867509d7ab5997cabe858a3abaa
Author: hsaputra <hsaputra@apache.org>
Date:   2015-10-02T22:41:30Z

    Remove Pact from the file names of teh flink-runtime and flink-clients modules.

----


> [REFACTOR] Remove Pact from class and file names since it is no longer valid reference
> --------------------------------------------------------------------------------------
>
>                 Key: FLINK-2815
>                 URL: https://issues.apache.org/jira/browse/FLINK-2815
>             Project: Flink
>          Issue Type: Task
>            Reporter: Henry Saputra
>            Assignee: Henry Saputra
>            Priority: Minor
>
> Remove Pact word from class and file names in Apache Flink.
> Pact was the name used in Stratosphere time to refer to concept of distributed datasets
(similar to Flink Dataset).
> It was used when Pact and Nephele still separate concept.
> As part of 0.10 cleanup effort, let's remove the Pact names to avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message