flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2815) [REFACTOR] Remove Pact from class and file names since it is no longer valid reference
Date Sun, 04 Oct 2015 20:07:26 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942799#comment-14942799
] 

ASF GitHub Bot commented on FLINK-2815:
---------------------------------------

Github user chiwanpark commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1218#discussion_r41101714
  
    --- Diff: flink-staging/flink-tez/src/main/java/org/apache/flink/tez/runtime/TezTask.java
---
    @@ -402,7 +402,7 @@ private void initInputLocalStrategy(int inputNum) throws Exception
{
     						localStub = initStub(userCodeFunctionType);
     					} catch (Exception e) {
     						throw new RuntimeException("Initializing the user code and the configuration failed"
+
    -								e.getMessage() == null ? "." : ": " + e.getMessage(), e);
    +								(e.getMessage() == null ? "." : ": ") + e.getMessage(), e);
    --- End diff --
    
    It seems wrong parenthesis. If `e.getMessage()` is `null`, there is concatenation of `"."`
and `null`.


> [REFACTOR] Remove Pact from class and file names since it is no longer valid reference
> --------------------------------------------------------------------------------------
>
>                 Key: FLINK-2815
>                 URL: https://issues.apache.org/jira/browse/FLINK-2815
>             Project: Flink
>          Issue Type: Task
>            Reporter: Henry Saputra
>            Assignee: Henry Saputra
>            Priority: Minor
>
> Remove Pact word from class and file names in Apache Flink.
> Pact was the name used in Stratosphere time to refer to concept of distributed datasets
(similar to Flink Dataset).
> It was used when Pact and Nephele still separate concept.
> As part of 0.10 cleanup effort, let's remove the Pact names to avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message