flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggevay <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2809] [scala-api] Added UnitTypeInfo an...
Date Fri, 02 Oct 2015 16:40:13 GMT
GitHub user ggevay opened a pull request:

    https://github.com/apache/flink/pull/1217

    [FLINK-2809] [scala-api] Added UnitTypeInfo and UnitSerializer.

    Created UnitTypeInfo and UnitSerializer, which will be created for a DataSet[Unit].
    Also added a test.
    
    There is a funny situation in CollectionInputFormat.checkCollection: when ExecutionEnvironment.fromCollection
calls it, the call to type.getTypeClass() returns void.class, even though it should be classOf[Unit].
This is probably some automatic conversion that happens when classOf[Unit] passes from the
Scala world to the Java world. I worked around this by adding a check for this specific case.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ggevay/flink unitTypeInfo

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1217.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1217
    
----
commit 0fe37101586cd01148fe4bb629f8ad743a32778d
Author: Gabor Gevay <ggab90@gmail.com>
Date:   2015-10-02T16:04:59Z

    [FLINK-2809] [scala-api] Added UnitTypeInfo and UnitSerializer.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message