flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chiwanpark <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...
Date Mon, 02 Nov 2015 16:43:53 GMT
Github user chiwanpark commented on the pull request:

    https://github.com/apache/flink/pull/1220#issuecomment-153078409
  
    Hi @danielblazevski, Thanks for updating your pull request. I'll review this soon. From
short review, I think that we have to split predict method into two methods because lots of
`if(useQuadTree)` statements are duplicated.
    
    I suggest creating two methods into `PredicateDataSetOperation`. One is finding kNN with
quad-tree and the other is not. We can pass testing data set and training data set to the
methods and receive result of the methods. I mean the logic in L191-L270 of `KNN.scala`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message