flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danielblazevski <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...
Date Mon, 02 Nov 2015 16:50:21 GMT
Github user danielblazevski commented on the pull request:

    https://github.com/apache/flink/pull/1220#issuecomment-153080192
  
    I'm not as keen on creating two methods @chiwanpark since there will be substantial overlap
of code-- if we want to make a change in the future, we'd have to change two methods, and
if we have to debug, we have to debug two methods.  And 3 `if(useQuadTree)` statements is
not so bad, two of which are less than 5 lines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message