flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request: Out-of-core state backend for JDBC databases
Date Tue, 03 Nov 2015 10:10:56 GMT
Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/1305#issuecomment-153305943
  
    Just some remarks:
     - `DummyEnvironment` seems unnecessary, we already have `StreamMockEnvironment`. I think
it could be reused.
    
    - In the first version you had both the timestamp and checkpoint and recovery/key lookup
took both into account. The recent version uses just the timestamp for lookup. Both introduce
the new restore timestamp in the restore methods.
    
    - The cleanup of failed checkpoints took into account the checkpoint and the recovery
timestamp, but I think the recovery timestamp was always redundant since the condition in
the SQL statement would always hold.
    
    => I think the timestamp is not needed. Can't everything be implemented by just using
the (monotonically rising) checkpoint IDs?
    
    Also, this is unrelated but maybe @StephanEwen or @gyfora know: Why to we have the `allOrNothingState`
in `CheckpointCoordinator.restoreLatestCheckpointedState`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message