flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2974] Add periodic offset committer for...
Date Wed, 11 Nov 2015 13:36:49 GMT
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1341#issuecomment-155786742
  
    Can you also move the periodic offset committer into the `run()` methods? Saves another
field that may have concurrent access. The run methods can make sure it initializes and cleans
up, no other functions need ever worry about the committer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message