flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...
Date Tue, 17 Nov 2015 18:41:25 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1338#discussion_r45100395
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandler.java
---
    @@ -113,7 +117,17 @@ private void respondAsLeader(ChannelHandlerContext ctx, Routed routed,
ActorGate
     		DefaultFullHttpResponse response;
     
     		try {
    -			String result = handler.handleRequest(routed.pathParams(), jobManager);
    +			Map<String, String> params = routed.pathParams();
    --- End diff --
    
    If you pass two maps (routed + query) then this is much less effort per request, and keeps
the types of parameters nicely separated.
    
    Also: Why do you need the query parameter here? This handler is the base for REST style
calls, it should never need query parameters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message