flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...
Date Tue, 17 Nov 2015 19:00:49 GMT
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1338#issuecomment-157471191
  
    The screenshots look very nice, this will be a good feature!
    
    A few things in the internals could be cleaned up:
      - Mixing of path and query params into one map
      - Putting endpoint address into the map
      - Error handling seems to always give a "Bad Request" error code. Would be good to react
to that properly, return a "Not Fount" or "Already Exists", or whatever, specific to the situation.
This may require to create an Exception class (RequestException) that contains the response
message and desired return code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message