flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2974] Add periodic offset committer for...
Date Fri, 20 Nov 2015 11:53:27 GMT
Github user StephanEwen commented on a diff in the pull request:

    --- Diff: flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer.java
    @@ -290,9 +291,6 @@ public FlinkKafkaConsumer(String topic, DeserializationSchema<T>
     		LOG.info("Topic {} has {} partitions", topic, partitions.length);
    -		// make sure that we take care of the committing
    -		props.setProperty("enable.auto.commit", "false");
    --- End diff --
    Is this not necessary, because the low-level consumer does not respect it anyways?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message