flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2974] Add periodic offset committer for...
Date Fri, 20 Nov 2015 11:58:51 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1341#discussion_r45461871
  
    --- Diff: flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer.java
---
    @@ -567,6 +588,76 @@ public void notifyCheckpointComplete(long checkpointId) throws Exception
{
     		}
     		return partitionsToSub;
     	}
    +
    +	/**
    +	 * Thread to periodically commit the current read offset into Zookeeper.
    +	 */
    +	private static class PeriodicOffsetCommitter extends Thread {
    +		private long commitInterval;
    +		private volatile boolean running = true;
    +		private volatile Thread self;
    +		private FlinkKafkaConsumer consumer;
    +		private final Object stateUpdateLock = new Object();
    --- End diff --
    
    You can probably drop this lock, it is used nowhere. If you want to lock, you need to
lock on the proper checkpoint lock.
    
    Locking may not be necessary, as these offsets are only some rough inaccurate notion of
progress anyways, if checkpointing is not enabled.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message