flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...
Date Thu, 26 Nov 2015 11:08:56 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1398#discussion_r45967336
  
    --- Diff: flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/FlinkTopologyContext.java
---
    @@ -27,13 +27,12 @@
     import backtype.storm.state.ISubscribedState;
     import backtype.storm.task.TopologyContext;
     import backtype.storm.tuple.Fields;
    +import clojure.lang.Atom;
     
    --- End diff --
    
    Not sure who is bullying whom :) Look at the classes and you will see that all imports
are arranged like this. We want to be consistent, right? According to your suggestion, I changed
the other import statements which were just reformatting.
    
    Open source is often about compromises. Very rarely you will find that the code style
of a person reflects exactly how you would do it. I'm making compromises and changing things
as you like them. That's fine for me. Please don't give me a harder time by blaming my employer.
I'm not aware I have done something like this to you. Next time you get blamed for something
like this, please contact me and I'll try to help you. I don't think this is the right place
to sort out things.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message