flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7) [GitHub] Enable Range Partitioner
Date Wed, 04 Nov 2015 23:38:27 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990724#comment-14990724
] 

ASF GitHub Bot commented on FLINK-7:
------------------------------------

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1255#issuecomment-153905286
  
    Hi @ChengXiangLi, sorry for the long reviewing delay.
    The PR is definitely moving in the right direction! I added a couple of comments in-line.
Please let me know if you have questions or would like to discuss some of the comments.
    
    We will also need a few tests that check the OptimizedPlan that is returned by the optimizer.
We have a few tests in place that check for example that correct execution strategies are
chosen by the optimizer. Since we manually rewrite the plan, it would be good to have tests
that verify our changes, for example for cases where an operator has multiple outputs of which
only one or all require range partitioning. Please have a look at `PartitionOperatorTest`
and other tests in the `flink-optimizer` module.
    
    Best, Fabian


> [GitHub] Enable Range Partitioner
> ---------------------------------
>
>                 Key: FLINK-7
>                 URL: https://issues.apache.org/jira/browse/FLINK-7
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Runtime
>            Reporter: GitHub Import
>            Assignee: Chengxiang Li
>             Fix For: pre-apache
>
>
> The range partitioner is currently disabled. We need to implement the following aspects:
> 1) Distribution information, if available, must be propagated back together with the
ordering property.
> 2) A generic bucket lookup structure (currently specific to PactRecord).
> Tests to re-enable after fixing this issue:
>  - TeraSortITCase
>  - GlobalSortingITCase
>  - GlobalSortingMixedOrderITCase
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/issues/7
> Created by: [StephanEwen|https://github.com/StephanEwen]
> Labels: core, enhancement, optimizer, 
> Milestone: Release 0.4
> Assignee: [fhueske|https://github.com/fhueske]
> Created at: Fri Apr 26 13:48:24 CEST 2013
> State: open



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message