flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2624) RabbitMQ source / sink should participate in checkpointing
Date Fri, 27 Nov 2015 13:49:11 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029886#comment-15029886
] 

ASF GitHub Bot commented on FLINK-2624:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1243#discussion_r46048074
  
    --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java
---
    @@ -102,4 +116,18 @@ public void run(SourceContext<OUT> ctx) throws Exception {
     	public void cancel() {
     		running = false;
     	}
    +
    +	@Override
    +	protected void acknowledgeIDs(List<Long> ids) {
    +		try {
    +			channel.basicAck(ids.get(ids.size() - 1), true);
    +		} catch (IOException e) {
    +			Log.error("Messages could not be acknowledged", e);
    --- End diff --
    
    If this fails, the checkpoint is incomplete. We should throw an Exception here.


> RabbitMQ source / sink should participate in checkpointing
> ----------------------------------------------------------
>
>                 Key: FLINK-2624
>                 URL: https://issues.apache.org/jira/browse/FLINK-2624
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming Connectors
>    Affects Versions: 0.10.0
>            Reporter: Stephan Ewen
>            Assignee: Hilmi Yildirim
>
> The RabbitMQ connector does not offer any fault tolerance guarantees right now, because
it does not participate in the checkpointing.
> We should integrate it in a similar was as the {{FlinkKafkaConsumer}} is integrated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message