flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2797) CLI: Missing option to submit jobs in detached mode
Date Mon, 02 Nov 2015 14:54:27 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985330#comment-14985330
] 

ASF GitHub Bot commented on FLINK-2797:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1214#discussion_r43635433
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/ContextEnvironment.java
---
    @@ -165,12 +181,65 @@ public ContextEnvironmentFactory(Client client, List<URL>
jarFilesToAttach,
     		
     		@Override
     		public ExecutionEnvironment createExecutionEnvironment() {
    -			ContextEnvironment env = new ContextEnvironment(client, jarFilesToAttach, classpathsToAttach,
    -					userCodeClassLoader, wait);
    -			if (defaultParallelism > 0) {
    -				env.setParallelism(defaultParallelism);
    +			if (wait || lastEnv == null) {
    --- End diff --
    
    Could you reformulate the if-else? That way the code would be more explicit:
    
    ```java
    // We only allow one detached environment in detached mode
    if (!wait && lastEnv != null) {
      throw new DetachedProgramException(..);
    }
    // regular submission flow
    lastEnv = ...
    ```


> CLI: Missing option to submit jobs in detached mode
> ---------------------------------------------------
>
>                 Key: FLINK-2797
>                 URL: https://issues.apache.org/jira/browse/FLINK-2797
>             Project: Flink
>          Issue Type: Bug
>          Components: Command-line client
>    Affects Versions: 0.9, 0.10
>            Reporter: Maximilian Michels
>            Assignee: Sachin Goel
>             Fix For: 0.10
>
>
> Jobs can only be submitted in detached mode using YARN but not on a standalone installation.
This has been requested by users who want to submit a job, get the job id, and later query
its status.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message