flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2837) FlinkTopologyBuilder cannot handle multiple input streams
Date Thu, 26 Nov 2015 11:09:10 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028560#comment-15028560

ASF GitHub Bot commented on FLINK-2837:

Github user mxm commented on a diff in the pull request:

    --- Diff: flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/FlinkTopologyContext.java
    @@ -27,13 +27,12 @@
     import backtype.storm.state.ISubscribedState;
     import backtype.storm.task.TopologyContext;
     import backtype.storm.tuple.Fields;
    +import clojure.lang.Atom;
    --- End diff --
    Not sure who is bullying whom :) Look at the classes and you will see that all imports
are arranged like this. We want to be consistent, right? According to your suggestion, I changed
the other import statements which were just reformatting.
    Open source is often about compromises. Very rarely you will find that the code style
of a person reflects exactly how you would do it. I'm making compromises and changing things
as you like them. That's fine for me. Please don't give me a harder time by blaming my employer.
I'm not aware I have done something like this to you. Next time you get blamed for something
like this, please contact me and I'll try to help you. I don't think this is the right place
to sort out things.

> FlinkTopologyBuilder cannot handle multiple input streams
> ---------------------------------------------------------
>                 Key: FLINK-2837
>                 URL: https://issues.apache.org/jira/browse/FLINK-2837
>             Project: Flink
>          Issue Type: Bug
>          Components: Storm Compatibility
>            Reporter: Matthias J. Sax
>            Assignee: Maximilian Michels
> FlinkTopologyBuilder cannot handle multiple input streams correctly. Instead of union
the incoming streams, it replicates the consuming bolt and each (logical) instance processes
one of the input streams.
> For example:
> {noformat}
> final FlinkTopologyBuilder builder = new FlinkTopologyBuilder();
> builder.setSpout(spoutId1, new FiniteRandomSpout(0, 10));
> builder.setSpout(spoutId2, new FiniteRandomSpout(1, 8));
> builder.setSpout(spoutId3, new FiniteRandomSpout(2, 13));
> builder.setBolt(boltId, new MergerBolt())
> 	.shuffleGrouping(spoutId1)
> 	.shuffleGrouping(spoutId2)
> 	.shuffleGrouping(spoutId3);
> builder.setBolt("sink", new BoltPrintSink(new SimpleOutputFormatter()))
> 	.shuffleGrouping(boltId);
> {noformat}
> will only print the data from a single source instead of all sources.

This message was sent by Atlassian JIRA

View raw message