flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2996) Add config entry to define BlobServer port
Date Tue, 24 Nov 2015 13:24:10 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024503#comment-15024503
] 

ASF GitHub Bot commented on FLINK-2996:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1394#discussion_r45733621
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java ---
    @@ -137,12 +139,29 @@ else if (config.containsKey(ConfigConstants.STATE_BACKEND) &&
     			this.shutdownHook = null;
     		}
     
    -		// start the server
    -		try {
    -			this.serverSocket = new ServerSocket(0, backlog);
    +		//  ----------------------- start the server -------------------
    +
    +		String serverPortRange = config.getString(ConfigConstants.BLOB_SERVER_PORT, ConfigConstants.DEFAULT_BLOB_SERVER_PORT);
    +		Iterator<Integer> ports = NetUtils.getPortRangeFromString(serverPortRange).iterator();
    +
    +		ServerSocket socketAttempt = null;
    +		while(ports.hasNext()) {
    --- End diff --
    
    Why do you have to test all ports here. Isn't it enough to take the first port for which
you can open a socket? Or is it important that you always take the last available port?


> Add config entry to define BlobServer port
> ------------------------------------------
>
>                 Key: FLINK-2996
>                 URL: https://issues.apache.org/jira/browse/FLINK-2996
>             Project: Flink
>          Issue Type: New Feature
>          Components: JobManager
>    Affects Versions: 0.10.0
>            Reporter: Stephan Ewen
>            Assignee: Robert Metzger
>             Fix For: 1.0.0, 0.10.1
>
>
> The blob server currently allocates a random port. To work better together with firewalled
clusters, it must be possible to optionally pre-configure the port to a specific value,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message