flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephan Ewen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3002) Add an EitherType to the Java API
Date Tue, 17 Nov 2015 15:45:11 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008861#comment-15008861
] 

Stephan Ewen commented on FLINK-3002:
-------------------------------------

All object reuse is optional to be done where possible. If you do not reuse the objects, it
is fine.

I think this is a fair case to not reuse them..

I would actually not return {{null}} in create instance, but create a {{Left}} (arbitrary).
That record is used in some parts as a reuse record, having it non null may prevent null pointers
in parts where we were not careful (just conservative coding). Since you do not reuse the
types in the methods anyways, it is really arbitrary what non-null object you create in {{createInstance()}}.

> Add an EitherType to the Java API
> ---------------------------------
>
>                 Key: FLINK-3002
>                 URL: https://issues.apache.org/jira/browse/FLINK-3002
>             Project: Flink
>          Issue Type: New Feature
>          Components: Java API
>    Affects Versions: 0.10.0
>            Reporter: Stephan Ewen
>            Assignee: Vasia Kalavri
>             Fix For: 1.0.0
>
>
> Either types are recurring patterns and should be serialized efficiently, so it makes
sense to add them to the core Java API.
> Since Java does not have such a type as of Java 8, we would need to add our own version.
> The Scala API handles the Scala Either Type already efficiently. I would not use the
Scala Either Type in the Java API, since we are trying to get the {{flink-java}} project "Scala
free" for people that don't use Scala and o not want to worry about Scala version matches
and mismatches.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message