flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...
Date Tue, 01 Dec 2015 13:30:13 GMT
Github user mxm commented on a diff in the pull request:

    --- Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/BoltWrapperTest.java
    @@ -265,12 +264,12 @@ public void testOpen() throws Exception {
     	public void testOpenSink() throws Exception {
     		final IRichBolt bolt = mock(IRichBolt.class);
    -		BoltWrapper<Object, Object> wrapper = new BoltWrapper<Object, Object>(bolt);
    +		BoltWrapper<Object, Object> wrapper = new BoltWrapper<Object, Object>(bolt,
"stream", "component");
     		wrapper.setup(createMockStreamTask(), new StreamConfig(new Configuration()), mock(Output.class));
    -		verify(bolt).prepare(any(Map.class), any(TopologyContext.class), any(OutputCollector.class));
    +		verify(bolt).prepare(any(Map.class), any(TopologyContext.class), isNotNull(OutputCollector.class));
    --- End diff --
    `any` matches also null (literally anything) but here I want to explicitly check `isNotNull`.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message