flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...
Date Tue, 01 Dec 2015 14:49:28 GMT
Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertexTest.java
    @@ -0,0 +1,41 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.runtime.executiongraph;
    +import org.apache.flink.runtime.JobException;
    +import org.apache.flink.runtime.jobgraph.JobVertex;
    +import org.junit.Assert;
    +import org.junit.Test;
    +import static org.mockito.Mockito.mock;
    +public class ExecutionJobVertexTest {
    +	@Test
    +	public void testReceivedStopSignal() throws JobException {
    --- End diff --
    I haven't said to drop it since it is already there. However, I'm questioning whether
it makes sense to write tests for setters/getters which don't involve complex logic. Effectively,
the test tests 
    public void setStopSignalReceived() {
    	this.receivedStopSignal = true;
    which is trivial. If we start testing these kind of methods, then I'm wondering why we
don't test other getters as well. From a test coverage point of view, it seems to be a bit
arbitrary to only test this setter then.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message