flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...
Date Tue, 01 Dec 2015 17:01:22 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r46305433
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
    @@ -732,6 +758,18 @@ else if (current == JobStatus.RESTARTING) {
     		}
     	}
     
    +	public void stop() {
    +		if(jobType == JobType.STREAMING) {
    +			for(ExecutionVertex ev : this.getAllExecutionVertices()) {
    +				if(ev.getNumberOfInputs() == 0) { // send signal to sources only
    +					ev.stop();
    +				}
    +			}
    +		} else {
    +			throw new RuntimeException("STOP is only supported by streaming jobs.");
    --- End diff --
    
    I think it is a bit hard to throw a `RuntimeException` in the case of a batch job. This
effectively means that whenever you call stop on a batch job, the `JobManager` will die with
a `RuntimeException`. I think it is better to simply tell the user that stop is not supported
for batch jobs or to call the cancel method for batch jobs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message