flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...
Date Fri, 04 Dec 2015 11:09:56 GMT
Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/750#issuecomment-161939523
  
    Have you added the tests for the REST interface? I couldn't find them. For the future
it might be helpful, if you simply push commits to your PR branch without squashing them.
It is impossible for me to see what you've actually changed with your last commit.
    
    Concerning the REST test case, I assume that you have to start a `JobManager` with the
`WebRuntimeMonitor` running. Then you submit a job and send a stop request to the web interface.
I would assume that you can use any HTTP client for that. Afterwards you can check the JSON
result and verify that the job has actually been stopped. That you can also directly do by
querying the `JobManager`.
    
    It would be important to also add such a test for the yarn use case. There you can take
a look at the existing yarn test cases to see how to start yarn cluster. It's important because
Yarn only allows GET requests, if I'm not mistaken.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message