flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3474] support partial aggregate
Date Tue, 01 Mar 2016 10:47:43 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1746#discussion_r54550270
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataset/DataSetAggregateRule.scala
---
    @@ -44,17 +45,24 @@ class DataSetAggregateRule
         val inputType = agg.getInput.getRowType()
     
         // add grouping fields, position keys in the input, and input type
    -    val aggregateFunction = AggregateFactory.createAggregateInstance(agg.getAggCallList,
    -        inputType, grouping)
    +    val aggregateResult = AggregateUtil.createOperatorFunctionsForAggregates(agg,
    --- End diff --
    
    `createOperatorFunctionsForAggregates` only uses `agg.getAggCallList()`. 
    Can you change `createOperatorFunctionsForAggregates` to expect `List<AggCall>`
instead of `FlinkAggregate`?
      


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message