flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3557] [stream, scala] Introduce seconda...
Date Tue, 01 Mar 2016 12:57:19 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1748#discussion_r54562674
  
    --- Diff: flink-streaming-scala/src/test/scala/org/apache/flink/streaming/api/scala/WindowFoldITCase.scala
---
    @@ -70,7 +70,7 @@ class WindowFoldITCase extends StreamingMultipleProgramsTestBase {
         source1
           .keyBy(0)
           .window(TumblingEventTimeWindows.of(Time.of(3, TimeUnit.MILLISECONDS)))
    -      .fold(("R:", 0), { (acc: (String, Int), v: (String, Int)) => (acc._1 + v._1,
acc._2 + v._2) })
    +      .fold(("R:", 0)){ (acc: (String, Int), v: (String, Int)) => (acc._1 + v._1,
acc._2 + v._2) }
    --- End diff --
    
    I have no strong preference here. I didn't introduce them initially because you also don't
insert a space between a function name and the first parameter list. But if you think that
it's better, I'll change it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message