flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3556] [runtime] Remove false check in H...
Date Tue, 01 Mar 2016 13:21:40 GMT
Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/1749#issuecomment-190722183
  
    Changes look good to me. Good catch @uce :-) +1 for merging.
    
    One minor thing: We check that the configuration contains the `ZOOKEEPER_RECOVERY_PATH`
and then give the configuration to the `FileSystemBlobStore`. Wouldn't it make more sense
to directly pass in the value of `ZOOKEEPER_RECOVERY_PATH` or do the checking of the correctness
of the value in the `FileSystemBlobStore`? If we pass the configuration, then we don't actually
know, which values will be used internally. This would untie the `BlobServer` and the `FileSystemBlobStore`
a bit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message