flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3554] [streaming] Emit a MAX Watermark ...
Date Tue, 01 Mar 2016 13:37:40 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1750#discussion_r54566693
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StoppableStreamSource.java
---
    @@ -41,7 +41,14 @@ public StoppableStreamSource(SRC sourceFunction) {
     		super(sourceFunction);
     	}
     
    +	/**
    +	 * Marks the source a stopped and calls {@link StoppableFunction#stop()} on the user
function.
    +	 */
     	public void stop() {
    +		// important: marking the source as stopped has to happen before the function is stopped.
    +		// the flag that tracks this status is volatile, to the memory model also guarantees
    --- End diff --
    
    typo in comment: to => so


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message